diff options
| author | Dan Carpenter | 2014-01-30 12:49:43 +0100 |
|---|---|---|
| committer | Herbert Xu | 2014-02-09 02:59:27 +0100 |
| commit | d167b6e1fb8ad386b17485ca88804d14f1695805 (patch) | |
| tree | 17edae29c16bc089530bf54512ca5f51de88d399 /crypto/crc32c_generic.c | |
| parent | crypto: mxs-dcp: Check the return value of stmp_reset_block() (diff) | |
| download | kernel-qcow2-linux-d167b6e1fb8ad386b17485ca88804d14f1695805.tar.gz kernel-qcow2-linux-d167b6e1fb8ad386b17485ca88804d14f1695805.tar.xz kernel-qcow2-linux-d167b6e1fb8ad386b17485ca88804d14f1695805.zip | |
hwrng: cleanup in hwrng_register()
My static checker complains that:
drivers/char/hw_random/core.c:341 hwrng_register()
warn: we tested 'old_rng' before and it was 'false'
The problem is that sometimes we test "if (!old_rng)" and sometimes we
test "if (must_register_misc)". The static checker knows they are
equivalent but a human being reading the code could easily be confused.
I have simplified the code by removing the "must_register_misc" variable
and I have removed the redundant check on "if (!old_rng)".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/crc32c_generic.c')
0 files changed, 0 insertions, 0 deletions