diff options
| author | Jean Delvare | 2005-04-19 06:16:59 +0200 |
|---|---|---|
| committer | Greg KH | 2005-04-19 06:16:59 +0200 |
| commit | 1d66c64c3cee10a465cd3f8bd9191bbeb718f650 (patch) | |
| tree | 1ef3e58b8ff25f850c5bf9bbdce08001751662c5 /crypto/crypto_null.c | |
| parent | [PATCH] I2C: via686a cleanups (diff) | |
| download | kernel-qcow2-linux-1d66c64c3cee10a465cd3f8bd9191bbeb718f650.tar.gz kernel-qcow2-linux-1d66c64c3cee10a465cd3f8bd9191bbeb718f650.tar.xz kernel-qcow2-linux-1d66c64c3cee10a465cd3f8bd9191bbeb718f650.zip | |
[PATCH] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers
The it87 and via686a hardware monitoring drivers each create a sysfs
file named "alarms" in R/W mode, while they should really create it in
read-only mode. Since we don't provide a store function for these files,
write attempts to these files will do something undefined (I guess) and
bad (I am sure). My own try resulted in a locked terminal (where I
attempted the write) and a 100% CPU load until next reboot.
As a side note, wouldn't it make sense to check, when creating sysfs
files, that readable files have a non-NULL show method, and writable
files have a non-NULL store method? I know drivers are not supposed to
do stupid things, but there is already a BUG_ON for several conditions
in sysfs_create_file, so maybe we could add two more?
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'crypto/crypto_null.c')
0 files changed, 0 insertions, 0 deletions