diff options
| author | Hanjun Guo | 2017-03-07 13:39:58 +0100 |
|---|---|---|
| committer | Lorenzo Pieralisi | 2017-03-21 19:09:51 +0100 |
| commit | c92bdfe8e7a6133fdbe8a2a08c68446dc2e52a17 (patch) | |
| tree | 57f6d0dbdb7e0915947ce769a5fd3b64a099d546 /drivers/acpi/arm64 | |
| parent | ACPI/IORT: Add missing comment for iort_dev_find_its_id() (diff) | |
| download | kernel-qcow2-linux-c92bdfe8e7a6133fdbe8a2a08c68446dc2e52a17.tar.gz kernel-qcow2-linux-c92bdfe8e7a6133fdbe8a2a08c68446dc2e52a17.tar.xz kernel-qcow2-linux-c92bdfe8e7a6133fdbe8a2a08c68446dc2e52a17.zip | |
ACPI/IORT: Rework iort_match_node_callback() return value handling
The return value handling in iort_match_node_callback() is
too convoluted; update the iort_match_node_callback() return
value handling to make code easier to read.
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
[lorenzo.pieralisi@arm.com: rewrote commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Tested-by: Ming Lei <ming.lei@canonical.com>
Tested-by: Wei Xu <xuwei5@hisilicon.com>
Tested-by: Sinan Kaya <okaya@codeaurora.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Tomasz Nowicki <tn@semihalf.com>
Diffstat (limited to 'drivers/acpi/arm64')
| -rw-r--r-- | drivers/acpi/arm64/iort.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c index abc5774148d7..a6b807d64565 100644 --- a/drivers/acpi/arm64/iort.c +++ b/drivers/acpi/arm64/iort.c @@ -253,17 +253,15 @@ static acpi_status iort_match_node_callback(struct acpi_iort_node *node, void *context) { struct device *dev = context; - acpi_status status; + acpi_status status = AE_NOT_FOUND; if (node->type == ACPI_IORT_NODE_NAMED_COMPONENT) { struct acpi_buffer buf = { ACPI_ALLOCATE_BUFFER, NULL }; struct acpi_device *adev = to_acpi_device_node(dev->fwnode); struct acpi_iort_named_component *ncomp; - if (!adev) { - status = AE_NOT_FOUND; + if (!adev) goto out; - } status = acpi_get_name(adev->handle, ACPI_FULL_PATHNAME, &buf); if (ACPI_FAILURE(status)) { @@ -289,8 +287,6 @@ static acpi_status iort_match_node_callback(struct acpi_iort_node *node, */ status = pci_rc->pci_segment_number == pci_domain_nr(bus) ? AE_OK : AE_NOT_FOUND; - } else { - status = AE_NOT_FOUND; } out: return status; |