diff options
| author | Gustavo A. R. Silva | 2017-10-12 21:19:16 +0200 |
|---|---|---|
| committer | Tejun Heo | 2017-10-23 16:06:09 +0200 |
| commit | 05b83605992b3d6cd53f8d339842a3b4530ab6e8 (patch) | |
| tree | 5a00af928601fbf1cfc62348be889ad3e4594a1d /drivers/ata/libata-core.c | |
| parent | ata: sata_mv: remove a redundant assignment to pointer ehi (diff) | |
| download | kernel-qcow2-linux-05b83605992b3d6cd53f8d339842a3b4530ab6e8.tar.gz kernel-qcow2-linux-05b83605992b3d6cd53f8d339842a3b4530ab6e8.tar.xz kernel-qcow2-linux-05b83605992b3d6cd53f8d339842a3b4530ab6e8.zip | |
ata: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
In cases where a "drop through" comment was already in place, I replaced
it with a proper "fall through" comment, which is what GCC is expecting
to find.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata/libata-core.c')
| -rw-r--r-- | drivers/ata/libata-core.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 29e351669353..5b1851056ec4 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -1879,6 +1879,7 @@ retry: switch (class) { case ATA_DEV_SEMB: class = ATA_DEV_ATA; /* some hard drives report SEMB sig */ + /* fall through */ case ATA_DEV_ATA: case ATA_DEV_ZAC: tf.command = ATA_CMD_ID_ATA; @@ -2975,6 +2976,7 @@ int ata_bus_probe(struct ata_port *ap) case -ENODEV: /* give it just one more chance */ tries[dev->devno] = min(tries[dev->devno], 1); + /* fall through */ case -EIO: if (tries[dev->devno] == 1) { /* This is the last chance, better to slow @@ -3462,6 +3464,7 @@ int ata_down_xfermask_limit(struct ata_device *dev, unsigned int sel) case ATA_DNXFER_FORCE_PIO0: pio_mask &= 1; + /* fall through */ case ATA_DNXFER_FORCE_PIO: mwdma_mask = 0; udma_mask = 0; |