diff options
| author | Tejun Heo | 2015-08-03 17:41:33 +0200 |
|---|---|---|
| committer | Tejun Heo | 2015-08-03 17:41:33 +0200 |
| commit | fe16d4f202c59a560533a223bc6375739ee30944 (patch) | |
| tree | 56bb840c5826263d17373d9b1bcbbbcccd8173b2 /drivers/ata/libata-scsi.c | |
| parent | ata: ahci_brcmstb: Fix warnings with CONFIG_PM_SLEEP=n (diff) | |
| download | kernel-qcow2-linux-fe16d4f202c59a560533a223bc6375739ee30944.tar.gz kernel-qcow2-linux-fe16d4f202c59a560533a223bc6375739ee30944.tar.xz kernel-qcow2-linux-fe16d4f202c59a560533a223bc6375739ee30944.zip | |
Revert "libata-eh: Set 'information' field for autosense"
This reverts commit a1524f226a02aa6edebd90ae0752e97cfd78b159.
As implemented, ACS-4 sense reporting for ATA devices bypasses error
diagnosis and handling in libata degrading EH behavior significantly.
Revert the related changes for now.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>
Cc: stable@vger.kernel.org #v4.1+
Diffstat (limited to 'drivers/ata/libata-scsi.c')
| -rw-r--r-- | drivers/ata/libata-scsi.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 641a61a59e89..e1ecd2ab3724 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -280,18 +280,6 @@ void ata_scsi_set_sense(struct scsi_cmnd *cmd, u8 sk, u8 asc, u8 ascq) scsi_build_sense_buffer(0, cmd->sense_buffer, sk, asc, ascq); } -void ata_scsi_set_sense_information(struct scsi_cmnd *cmd, - const struct ata_taskfile *tf) -{ - u64 information; - - if (!cmd) - return; - - information = ata_tf_read_block(tf, NULL); - scsi_set_sense_information(cmd->sense_buffer, information); -} - static ssize_t ata_scsi_em_message_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) |