diff options
| author | Lars Ellenberg | 2010-12-17 23:58:41 +0100 |
|---|---|---|
| committer | Philipp Reisner | 2011-03-10 11:43:37 +0100 |
| commit | 7648cdfe52daf0ca4fa9489879dea9e089b0dfe1 (patch) | |
| tree | 7dd711ec5bda5ef0429bf94205dbbf7fe1659d82 /drivers/block/drbd/drbd_bitmap.c | |
| parent | drbd: serialize sending of resync uuid with pending w_send_oos (diff) | |
| download | kernel-qcow2-linux-7648cdfe52daf0ca4fa9489879dea9e089b0dfe1.tar.gz kernel-qcow2-linux-7648cdfe52daf0ca4fa9489879dea9e089b0dfe1.tar.xz kernel-qcow2-linux-7648cdfe52daf0ca4fa9489879dea9e089b0dfe1.zip | |
drbd: be less noisy with some log messages
We expect changes to a bitmap page in drbd_bm_write_page,
that's why we submit a copy page.
If a page changes during global writeout, that would be unexpected,
and reason to warn, though.
Also, often page writeout can be skipped (on activity log transactions
during normal operation, for example), no need to log that everytime.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block/drbd/drbd_bitmap.c')
| -rw-r--r-- | drivers/block/drbd/drbd_bitmap.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c index 423dede45844..314a3632303b 100644 --- a/drivers/block/drbd/drbd_bitmap.c +++ b/drivers/block/drbd/drbd_bitmap.c @@ -920,8 +920,9 @@ static void bm_async_io_complete(struct bio *bio, int error) if (!error && !uptodate) error = -EIO; - if (!bm_test_page_unchanged(b->bm_pages[idx])) - dev_info(DEV, "bitmap page idx %u changed during IO!\n", idx); + if ((ctx->flags & BM_AIO_COPY_PAGES) == 0 && + !bm_test_page_unchanged(b->bm_pages[idx])) + dev_warn(DEV, "bitmap page idx %u changed during IO!\n", idx); if (error) { /* ctx error will hold the completed-last non-zero error code, @@ -1135,7 +1136,7 @@ int drbd_bm_write_page(struct drbd_conf *mdev, unsigned int idx) __must_hold(loc struct bm_aio_ctx ctx = { .flags = BM_AIO_COPY_PAGES, }; if (bm_test_page_unchanged(mdev->bitmap->bm_pages[idx])) { - dev_info(DEV, "skipped bm page write for idx %u\n", idx); + dynamic_dev_dbg(DEV, "skipped bm page write for idx %u\n", idx); return 0; } |