diff options
| author | Lars Ellenberg | 2012-04-25 23:06:45 +0200 |
|---|---|---|
| committer | Philipp Reisner | 2012-05-09 15:17:00 +0200 |
| commit | 0e8488ade26b4b16a9745aa15ecb88c3fb1cb953 (patch) | |
| tree | 368b5bf6ddf7a687303a6e01ce33460dbc096287 /drivers/block/drbd/drbd_main.c | |
| parent | drbd: fix race between drbdadm invalidate/verify and finishing resync (diff) | |
| download | kernel-qcow2-linux-0e8488ade26b4b16a9745aa15ecb88c3fb1cb953.tar.gz kernel-qcow2-linux-0e8488ade26b4b16a9745aa15ecb88c3fb1cb953.tar.xz kernel-qcow2-linux-0e8488ade26b4b16a9745aa15ecb88c3fb1cb953.zip | |
drbd: allow bitmap to change during writeout from resync_finished
Symptom: messages similar to
"FIXME asender in bm_change_bits_to,
bitmap locked for 'write from resync_finished' by worker"
If a resync or verify is finished (or aborted), a full bitmap writeout
is triggered. If we have ongoing local IO, the bitmap may still change
during that writeout, pending and not yet processed acks may cause bits
to be cleared, while new writes may cause bits to be to be set.
To fix this, introduce the drbd_bm_write_copy_pages() variant.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block/drbd/drbd_main.c')
| -rw-r--r-- | drivers/block/drbd/drbd_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index ab501b23b50e..d830116781f9 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -1698,8 +1698,8 @@ static void after_state_ch(struct drbd_conf *mdev, union drbd_state os, * No harm done if some bits change during this phase. */ if (os.conn > C_CONNECTED && ns.conn <= C_CONNECTED && get_ldev(mdev)) { - drbd_queue_bitmap_io(mdev, &drbd_bm_write, NULL, - "write from resync_finished", BM_LOCKED_SET_ALLOWED); + drbd_queue_bitmap_io(mdev, &drbd_bm_write_copy_pages, NULL, + "write from resync_finished", BM_LOCKED_CHANGE_ALLOWED); put_ldev(mdev); } |