summaryrefslogtreecommitdiffstats
path: root/drivers/block/drbd/drbd_main.c
diff options
context:
space:
mode:
authorAndreas Gruenbacher2011-03-14 17:27:45 +0100
committerPhilipp Reisner2011-10-14 16:47:53 +0200
commit6e849ce88cd63efc6650a1826d18ed742eb31999 (patch)
treea8cf7681d66c6a4b46c0aa803a74649d15958a1b /drivers/block/drbd/drbd_main.c
parentdrbd: Remove redundant check (diff)
downloadkernel-qcow2-linux-6e849ce88cd63efc6650a1826d18ed742eb31999.tar.gz
kernel-qcow2-linux-6e849ce88cd63efc6650a1826d18ed742eb31999.tar.xz
kernel-qcow2-linux-6e849ce88cd63efc6650a1826d18ed742eb31999.zip
drbd: Get rid of P_MAX_CMD
Instead of artificially enlarging the command decoding arrays to P_MAX_CMD entries, check if an index is within the valid range using the ARRAY_SIZE() macro. Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block/drbd/drbd_main.c')
-rw-r--r--drivers/block/drbd/drbd_main.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index b93c5eccd73d..f43752fb5b52 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -3019,7 +3019,6 @@ const char *cmdname(enum drbd_packet cmd)
[P_DELAY_PROBE] = "DelayProbe",
[P_OUT_OF_SYNC] = "OutOfSync",
[P_RETRY_WRITE] = "RetryWrite",
- [P_MAX_CMD] = NULL,
};
if (cmd == P_HAND_SHAKE_M)
@@ -3028,7 +3027,7 @@ const char *cmdname(enum drbd_packet cmd)
return "HandShakeS";
if (cmd == P_HAND_SHAKE)
return "HandShake";
- if (cmd >= P_MAX_CMD)
+ if (cmd >= ARRAY_SIZE(cmdnames))
return "Unknown";
return cmdnames[cmd];
}