diff options
| author | Lars Ellenberg | 2010-10-07 16:07:55 +0200 |
|---|---|---|
| committer | Philipp Reisner | 2010-10-14 18:38:48 +0200 |
| commit | af85e8e83d160f72a10e4467852646ac08614260 (patch) | |
| tree | b2c842d6129065bbdd787a810038752e6239b0ef /drivers/block/drbd/drbd_main.c | |
| parent | drbd: allow for explicit resync-finished notifications (diff) | |
| download | kernel-qcow2-linux-af85e8e83d160f72a10e4467852646ac08614260.tar.gz kernel-qcow2-linux-af85e8e83d160f72a10e4467852646ac08614260.tar.xz kernel-qcow2-linux-af85e8e83d160f72a10e4467852646ac08614260.zip | |
drbd: fix for spurious fullsync (uuids rotated too fast)
If it was an "empty" resync, the SyncSource may have already "finished"
the resync and rotated the UUIDs, before noticing the connection loss
(and generating a new uuid, if Primary, rotating again), while the
SyncTarget did not change its uuids at all, or only got to the previous
sync-uuid.
This would then again lead to a full sync on next handshake
(see also Bug #251).
Fix:
Use explicit resync finished notification even for empty resyncs,
do not finish an empty resync implicitly on the SyncSource.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block/drbd/drbd_main.c')
| -rw-r--r-- | drivers/block/drbd/drbd_main.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index accb37d1215f..63f45d730f3f 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -1426,6 +1426,11 @@ static void after_state_ch(struct drbd_conf *mdev, union drbd_state os, (os.user_isp && !ns.user_isp)) resume_next_sg(mdev); + /* sync target done with resync. Explicitly notify peer, even though + * it should (at least for non-empty resyncs) already know itself. */ + if (os.disk < D_UP_TO_DATE && os.conn >= C_SYNC_SOURCE && ns.conn == C_CONNECTED) + drbd_send_state(mdev); + /* free tl_hash if we Got thawed and are C_STANDALONE */ if (ns.conn == C_STANDALONE && !is_susp(ns) && mdev->tl_hash) drbd_free_tl_hash(mdev); |