diff options
| author | Lars Ellenberg | 2016-06-14 00:26:10 +0200 |
|---|---|---|
| committer | Jens Axboe | 2016-06-14 05:43:03 +0200 |
| commit | c0065f98d5dd88e22bc35b89060b8bbf75f100c9 (patch) | |
| tree | ece4f6c3e14360f68e6383b7afff48dae3ab8458 /drivers/block/drbd/drbd_main.c | |
| parent | nvme: move the workaround for I/O queue-less controllers from PCIe to core (diff) | |
| download | kernel-qcow2-linux-c0065f98d5dd88e22bc35b89060b8bbf75f100c9.tar.gz kernel-qcow2-linux-c0065f98d5dd88e22bc35b89060b8bbf75f100c9.tar.xz kernel-qcow2-linux-c0065f98d5dd88e22bc35b89060b8bbf75f100c9.zip | |
drbd: bitmap bulk IO: do not always suspend IO
The intention was to only suspend IO if some normal bitmap operation is
supposed to be locked out, not always. If the bulk operation is flaged
as BM_LOCKED_CHANGE_ALLOWED, we do not need to suspend IO.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block/drbd/drbd_main.c')
| -rw-r--r-- | drivers/block/drbd/drbd_main.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 2b37744db0fa..2891631df596 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -3587,18 +3587,20 @@ void drbd_queue_bitmap_io(struct drbd_device *device, int drbd_bitmap_io(struct drbd_device *device, int (*io_fn)(struct drbd_device *), char *why, enum bm_flag flags) { + /* Only suspend io, if some operation is supposed to be locked out */ + const bool do_suspend_io = flags & (BM_DONT_CLEAR|BM_DONT_SET|BM_DONT_TEST); int rv; D_ASSERT(device, current != first_peer_device(device)->connection->worker.task); - if ((flags & BM_LOCKED_SET_ALLOWED) == 0) + if (do_suspend_io) drbd_suspend_io(device); drbd_bm_lock(device, why, flags); rv = io_fn(device); drbd_bm_unlock(device); - if ((flags & BM_LOCKED_SET_ALLOWED) == 0) + if (do_suspend_io) drbd_resume_io(device); return rv; |