diff options
| author | Jens Axboe | 2017-03-30 20:30:39 +0200 |
|---|---|---|
| committer | Jens Axboe | 2017-03-30 20:30:39 +0200 |
| commit | bf4907c05e615f6a1811d61c58d56da52f7e9954 (patch) | |
| tree | e63fd10fd38137403a56861e03bff6f1677d1ba7 /drivers/block/null_blk.c | |
| parent | block/sed-opal: fix spelling mistake: "Lifcycle" -> "Lifecycle" (diff) | |
| download | kernel-qcow2-linux-bf4907c05e615f6a1811d61c58d56da52f7e9954.tar.gz kernel-qcow2-linux-bf4907c05e615f6a1811d61c58d56da52f7e9954.tar.xz kernel-qcow2-linux-bf4907c05e615f6a1811d61c58d56da52f7e9954.zip | |
blk-mq: fix schedule-under-preempt for blocking drivers
Commit a4d907b6a33b unified the single and multi queue request handlers,
but in the process, it also screwed up the locking balance and calls
blk_mq_try_issue_directly() with the ctx preempt lock held. This is a
problem for drivers that have set BLK_MQ_F_BLOCKING, since now they
can't reliably sleep.
While in there, protect against similar issues in the future, by adding
a might_sleep() trigger in the BLOCKING path for direct issue or queue
run.
Reported-by: Josef Bacik <josef@toxicpanda.com>
Tested-by: Josef Bacik <josef@toxicpanda.com>
Fixes: a4d907b6a33b ("blk-mq: streamline blk_mq_make_request")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block/null_blk.c')
0 files changed, 0 insertions, 0 deletions