diff options
| author | Andreea-Cristina Bernat | 2014-08-18 16:41:01 +0200 |
|---|---|---|
| committer | Jens Axboe | 2014-11-04 21:17:08 +0100 |
| commit | 062261be4e39e35bdf2fba16a4b2d8a432ae8281 (patch) | |
| tree | a423860d3876bcecd1b09cf30c651114377ce04e /drivers/block | |
| parent | NVMe: Correctly handle IOCTL_SUBMIT_IO when cpus > online queues (diff) | |
| download | kernel-qcow2-linux-062261be4e39e35bdf2fba16a4b2d8a432ae8281.tar.gz kernel-qcow2-linux-062261be4e39e35bdf2fba16a4b2d8a432ae8281.tar.xz kernel-qcow2-linux-062261be4e39e35bdf2fba16a4b2d8a432ae8281.zip | |
nvme: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/nvme-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index 5d44c9344522..c1e3c1a101b8 100644 --- a/drivers/block/nvme-core.c +++ b/drivers/block/nvme-core.c @@ -1230,7 +1230,7 @@ static void nvme_free_queues(struct nvme_dev *dev, int lowest) for (i = dev->queue_count - 1; i >= lowest; i--) { nvmeq = raw_nvmeq(dev, i); - rcu_assign_pointer(dev->queues[i], NULL); + RCU_INIT_POINTER(dev->queues[i], NULL); llist_add(&nvmeq->node, &q_list); dev->queue_count--; } |