diff options
| author | John Kacur | 2009-12-16 01:46:06 +0100 |
|---|---|---|
| committer | Linus Torvalds | 2009-12-16 16:19:59 +0100 |
| commit | f29627c2a3df5732af84bc217df26d1c311f5112 (patch) | |
| tree | 170d0e203087f4cf592fbb9584a0345028860ae0 /drivers/char/efirtc.c | |
| parent | rtc: do not use container_of macro as an argument for to_platform_device (diff) | |
| download | kernel-qcow2-linux-f29627c2a3df5732af84bc217df26d1c311f5112.tar.gz kernel-qcow2-linux-f29627c2a3df5732af84bc217df26d1c311f5112.tar.xz kernel-qcow2-linux-f29627c2a3df5732af84bc217df26d1c311f5112.zip | |
efirtc: explicitly set llseek to no_llseek
Now that we've removed the BKL here, let's explicitly set llseek to
no_llseek since the default llseek is not used here.
The default_llseek function still contains the BKL. When we are auditing
code to see if we can remove the BKL, this is one of the hidden
considerations we need to take into account. i.e., is there
syncronization between code that has the BKL and llseek.
At the same time we remove the BKL it would be a good idea to do indicate
when no llseek function is required, so we don't have to revisit this code
again, when we are trying to determine if we can remove the BKL from the
default_llseek.
Signed-off-by: John Kacur <jkacur@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/efirtc.c')
| -rw-r--r-- | drivers/char/efirtc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c index 26a47dc88f61..53c524e7b829 100644 --- a/drivers/char/efirtc.c +++ b/drivers/char/efirtc.c @@ -285,6 +285,7 @@ static const struct file_operations efi_rtc_fops = { .unlocked_ioctl = efi_rtc_ioctl, .open = efi_rtc_open, .release = efi_rtc_close, + .llseek = no_llseek, }; static struct miscdevice efi_rtc_dev= { |