summaryrefslogtreecommitdiffstats
path: root/drivers/char/tpm/tpm_infineon.c
diff options
context:
space:
mode:
authorJarkko Sakkinen2019-02-08 17:30:58 +0100
committerJarkko Sakkinen2019-02-13 08:46:26 +0100
commitf5595f5baa30e009bf54d0d7653a9a0cc465be60 (patch)
tree87fc6fd0cbd081a44bf6dd96383976a74b625aee /drivers/char/tpm/tpm_infineon.c
parentselftests: add TPM 2.0 tests (diff)
downloadkernel-qcow2-linux-f5595f5baa30e009bf54d0d7653a9a0cc465be60.tar.gz
kernel-qcow2-linux-f5595f5baa30e009bf54d0d7653a9a0cc465be60.tar.xz
kernel-qcow2-linux-f5595f5baa30e009bf54d0d7653a9a0cc465be60.zip
tpm: Unify the send callback behaviour
The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main transmit functionality only cares about whether the transmit was successful or not and ignores the count completely. Suggested-by: Stefan Berger <stefanb@linux.ibm.com> Cc: stable@vger.kernel.org Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com> Tested-by: Alexander Steffen <Alexander.Steffen@infineon.com>
Diffstat (limited to 'drivers/char/tpm/tpm_infineon.c')
-rw-r--r--drivers/char/tpm/tpm_infineon.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm_infineon.c b/drivers/char/tpm/tpm_infineon.c
index d8f10047fbba..97f6d4fe0aee 100644
--- a/drivers/char/tpm/tpm_infineon.c
+++ b/drivers/char/tpm/tpm_infineon.c
@@ -354,7 +354,7 @@ static int tpm_inf_send(struct tpm_chip *chip, u8 * buf, size_t count)
for (i = 0; i < count; i++) {
wait_and_send(chip, buf[i]);
}
- return count;
+ return 0;
}
static void tpm_inf_cancel(struct tpm_chip *chip)