summaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorGustavo A. R. Silva2018-02-14 18:30:29 +0100
committerCorey Minyard2018-02-26 16:21:28 +0100
commitaaf1bbe90a36a6d11dbedc4a99b24096963280c8 (patch)
tree565803c13ab2289963bbf4492f8ed8001751a5c1 /drivers/char
parentipmi: add an Aspeed KCS IPMI BMC driver (diff)
downloadkernel-qcow2-linux-aaf1bbe90a36a6d11dbedc4a99b24096963280c8.tar.gz
kernel-qcow2-linux-aaf1bbe90a36a6d11dbedc4a99b24096963280c8.tar.xz
kernel-qcow2-linux-aaf1bbe90a36a6d11dbedc4a99b24096963280c8.zip
ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle_data
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1465255 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Cc: Haiyue Wang <haiyue.wang@linux.intel.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/ipmi/kcs_bmc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c
index 3a3498afa427..6476bfb79f44 100644
--- a/drivers/char/ipmi/kcs_bmc.c
+++ b/drivers/char/ipmi/kcs_bmc.c
@@ -95,6 +95,7 @@ static void kcs_bmc_handle_data(struct kcs_bmc *kcs_bmc)
switch (kcs_bmc->phase) {
case KCS_PHASE_WRITE_START:
kcs_bmc->phase = KCS_PHASE_WRITE_DATA;
+ /* fall through */
case KCS_PHASE_WRITE_DATA:
if (kcs_bmc->data_in_idx < KCS_MSG_BUFSIZ) {