summaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorCorentin Labbe2016-12-15 15:40:33 +0100
committerGreg Kroah-Hartman2017-01-10 21:46:41 +0100
commitf17c941cbcdccc4fef49a10622ce2ffd2321a143 (patch)
tree4d60fa6dfc7abb10b517dd3d4c22cdf4ec5c6a59 /drivers/char
parentmisc: mic: double free on ioctl error path (diff)
downloadkernel-qcow2-linux-f17c941cbcdccc4fef49a10622ce2ffd2321a143.tar.gz
kernel-qcow2-linux-f17c941cbcdccc4fef49a10622ce2ffd2321a143.tar.xz
kernel-qcow2-linux-f17c941cbcdccc4fef49a10622ce2ffd2321a143.zip
mmtimer: add member name to the miscdevice declaration
Since the struct miscdevice have many members, it is dangerous to init it without members name relying only on member order. This patch add member name to the init declaration. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/mmtimer.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/char/mmtimer.c b/drivers/char/mmtimer.c
index f786b18ac500..b708c85dc9c1 100644
--- a/drivers/char/mmtimer.c
+++ b/drivers/char/mmtimer.c
@@ -463,9 +463,9 @@ static int mmtimer_mmap(struct file *file, struct vm_area_struct *vma)
}
static struct miscdevice mmtimer_miscdev = {
- SGI_MMTIMER,
- MMTIMER_NAME,
- &mmtimer_fops
+ .minor = SGI_MMTIMER,
+ .name = MMTIMER_NAME,
+ .fops = &mmtimer_fops
};
static struct timespec sgi_clock_offset;