diff options
| author | Rafael J. Wysocki | 2015-05-04 22:53:28 +0200 |
|---|---|---|
| committer | Rafael J. Wysocki | 2015-05-04 22:53:28 +0200 |
| commit | a802ea96454570f3c526dd9d7ad8c706e570444d (patch) | |
| tree | 208a8a4c4d31ee2626c25109428483cf433100b7 /drivers/cpuidle/cpuidle.c | |
| parent | sched / idle: Move the default idle call code to a separate function (diff) | |
| download | kernel-qcow2-linux-a802ea96454570f3c526dd9d7ad8c706e570444d.tar.gz kernel-qcow2-linux-a802ea96454570f3c526dd9d7ad8c706e570444d.tar.xz kernel-qcow2-linux-a802ea96454570f3c526dd9d7ad8c706e570444d.zip | |
cpuidle: Check the sign of index in cpuidle_reflect()
Avoid calling the governor's ->reflect method if the state index
passed to cpuidle_reflect() is negative.
This allows the analogous check to be dropped from menu_reflect(),
so do that too, and ensures that arbitrary error codes can be
passed to cpuidle_reflect() as the index with no adverse
consequences.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Diffstat (limited to 'drivers/cpuidle/cpuidle.c')
| -rw-r--r-- | drivers/cpuidle/cpuidle.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index 61c417b9e53f..3b80b77a585d 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -249,7 +249,7 @@ int cpuidle_enter(struct cpuidle_driver *drv, struct cpuidle_device *dev, */ void cpuidle_reflect(struct cpuidle_device *dev, int index) { - if (cpuidle_curr_governor->reflect) + if (cpuidle_curr_governor->reflect && index >= 0) cpuidle_curr_governor->reflect(dev, index); } |