summaryrefslogtreecommitdiffstats
path: root/drivers/crypto/omap-des.c
diff options
context:
space:
mode:
authorAsaf Vertz2015-01-05 09:23:10 +0100
committerHerbert Xu2015-01-08 11:46:17 +0100
commit42d2e780c6239040ec29d404f87e752de3627e08 (patch)
tree1eeadf3c1b7324dba54e957ee83d61e8baaa177e /drivers/crypto/omap-des.c
parentcrypto: bfin_crc - Remove unnecessary KERN_ERR in bfin_crc.c (diff)
downloadkernel-qcow2-linux-42d2e780c6239040ec29d404f87e752de3627e08.tar.gz
kernel-qcow2-linux-42d2e780c6239040ec29d404f87e752de3627e08.tar.xz
kernel-qcow2-linux-42d2e780c6239040ec29d404f87e752de3627e08.zip
crypto: omap-des - fix BUG_ON condition
dd->total is unsigned so it won't do any good to check for negative value after subtracting instead of that we should check if the subtracted value is bigger than him This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/omap-des.c')
-rw-r--r--drivers/crypto/omap-des.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index e350f5be4d2e..0b8dcf5eb74e 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -965,9 +965,9 @@ static irqreturn_t omap_des_irq(int irq, void *dev_id)
}
}
- dd->total -= DES_BLOCK_SIZE;
+ BUG_ON(dd->total < DES_BLOCK_SIZE);
- BUG_ON(dd->total < 0);
+ dd->total -= DES_BLOCK_SIZE;
/* Clear IRQ status */
status &= ~DES_REG_IRQ_DATA_OUT;