diff options
| author | Stefan Richter | 2009-03-10 21:09:28 +0100 |
|---|---|---|
| committer | Stefan Richter | 2009-03-24 20:56:52 +0100 |
| commit | 7889b60ee71eafaf50699a154a2455424bb92daa (patch) | |
| tree | d5bb3a4d274bf186e32605284a34a36398475818 /drivers/firewire/fw-topology.c | |
| parent | firewire: core: simplify broadcast channel allocation (diff) | |
| download | kernel-qcow2-linux-7889b60ee71eafaf50699a154a2455424bb92daa.tar.gz kernel-qcow2-linux-7889b60ee71eafaf50699a154a2455424bb92daa.tar.xz kernel-qcow2-linux-7889b60ee71eafaf50699a154a2455424bb92daa.zip | |
firewire: core: optimize propagation of BROADCAST_CHANNEL
Cache the test result of whether a device implements BROADCAST_CHANNEL.
This minimizes traffic on the bus after each bus reset. A majority of
devices does not implement BROADCAST_CHANNEL.
Remove busy retries; just rely on the hardware to retry requests to busy
responders. Remove unnecessary log messages.
Rename the flag is_irm to broadcast_channel_allocated to better reflect
its meaning. Reset the flag earlier in fw_core_handle_bus_reset.
Pass the generation down as a call parameter; that way generation can't
be newer than card->broadcast_channel_allocated and device->node_id.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/fw-topology.c')
| -rw-r--r-- | drivers/firewire/fw-topology.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/firewire/fw-topology.c b/drivers/firewire/fw-topology.c index b44131cf0c62..d0deecc4de93 100644 --- a/drivers/firewire/fw-topology.c +++ b/drivers/firewire/fw-topology.c @@ -526,6 +526,7 @@ void fw_core_handle_bus_reset(struct fw_card *card, int node_id, int generation, spin_lock_irqsave(&card->lock, flags); + card->broadcast_channel_allocated = false; card->node_id = node_id; /* * Update node_id before generation to prevent anybody from using |