diff options
| author | Sudeep Holla | 2018-05-09 18:52:06 +0200 |
|---|---|---|
| committer | Sudeep Holla | 2018-05-09 18:52:06 +0200 |
| commit | 354b2e36d7dea9f5d67945498bbbf65551d72e15 (patch) | |
| tree | df85d2ad4a9a96a40c85255f3b471627ffdbc2cf /drivers/firmware/arm_scmi/common.h | |
| parent | Linux 4.17-rc1 (diff) | |
| download | kernel-qcow2-linux-354b2e36d7dea9f5d67945498bbbf65551d72e15.tar.gz kernel-qcow2-linux-354b2e36d7dea9f5d67945498bbbf65551d72e15.tar.xz kernel-qcow2-linux-354b2e36d7dea9f5d67945498bbbf65551d72e15.zip | |
firmware: arm_scmi: improve code readability using bitfield accessor macros
By using FIELD_{FIT,GET,PREP} and GENMASK macro accessors we can avoid
some clumpsy custom shifting and masking macros and also improve the
code better readability.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'drivers/firmware/arm_scmi/common.h')
| -rw-r--r-- | drivers/firmware/arm_scmi/common.h | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index 0c30234f9098..e8f332c9c469 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -7,6 +7,7 @@ * Copyright (C) 2018 ARM Ltd. */ +#include <linux/bitfield.h> #include <linux/completion.h> #include <linux/device.h> #include <linux/errno.h> @@ -14,10 +15,10 @@ #include <linux/scmi_protocol.h> #include <linux/types.h> -#define PROTOCOL_REV_MINOR_BITS 16 -#define PROTOCOL_REV_MINOR_MASK ((1U << PROTOCOL_REV_MINOR_BITS) - 1) -#define PROTOCOL_REV_MAJOR(x) ((x) >> PROTOCOL_REV_MINOR_BITS) -#define PROTOCOL_REV_MINOR(x) ((x) & PROTOCOL_REV_MINOR_MASK) +#define PROTOCOL_REV_MINOR_MASK GENMASK(15, 0) +#define PROTOCOL_REV_MAJOR_MASK GENMASK(31, 16) +#define PROTOCOL_REV_MAJOR(x) (u16)(FIELD_GET(PROTOCOL_REV_MAJOR_MASK, (x))) +#define PROTOCOL_REV_MINOR(x) (u16)(FIELD_GET(PROTOCOL_REV_MINOR_MASK, (x))) #define MAX_PROTOCOLS_IMP 16 #define MAX_OPPS 16 |