diff options
| author | Sudeep Holla | 2018-05-09 18:52:06 +0200 |
|---|---|---|
| committer | Sudeep Holla | 2018-05-10 11:52:00 +0200 |
| commit | 632de8f542bcd44c756637da0e7d824e7129e496 (patch) | |
| tree | f9cad09e2696d24b39d261e790747e74939d370b /drivers/firmware/arm_scmi | |
| parent | firmware: arm_scmi: improve exit paths and code readability (diff) | |
| download | kernel-qcow2-linux-632de8f542bcd44c756637da0e7d824e7129e496.tar.gz kernel-qcow2-linux-632de8f542bcd44c756637da0e7d824e7129e496.tar.xz kernel-qcow2-linux-632de8f542bcd44c756637da0e7d824e7129e496.zip | |
firmware: arm_scmi: simplify exit path by returning on error
Yet another nasty indentation left out during code restructuring. It's
must simpler to return on error instead of having unnecessary indentation.
Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'drivers/firmware/arm_scmi')
| -rw-r--r-- | drivers/firmware/arm_scmi/driver.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 4087d6c50ecd..e996395af5f2 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -687,11 +687,12 @@ static int scmi_remove(struct platform_device *pdev) list_del(&info->node); mutex_unlock(&scmi_list_mutex); - if (!ret) { - /* Safe to free channels since no more users */ - ret = idr_for_each(idr, scmi_mbox_free_channel, idr); - idr_destroy(&info->tx_idr); - } + if (ret) + return ret; + + /* Safe to free channels since no more users */ + ret = idr_for_each(idr, scmi_mbox_free_channel, idr); + idr_destroy(&info->tx_idr); return ret; } |