diff options
| author | Matt Fleming | 2014-03-17 10:17:28 +0100 |
|---|---|---|
| committer | Matt Fleming | 2014-04-17 14:53:34 +0200 |
| commit | e003bbee2a6a19a4c733335989284caf1b179e0d (patch) | |
| tree | 80c92271ca01ceaabdbd43d13bcda29b11789b2a /drivers/firmware/efi/efivars.c | |
| parent | efivars: Use local variables instead of a pointer dereference (diff) | |
| download | kernel-qcow2-linux-e003bbee2a6a19a4c733335989284caf1b179e0d.tar.gz kernel-qcow2-linux-e003bbee2a6a19a4c733335989284caf1b179e0d.tar.xz kernel-qcow2-linux-e003bbee2a6a19a4c733335989284caf1b179e0d.zip | |
efivars: Check size of user object
Unbelieavably there are no checks to see whether the data structure
passed to 'new_var' and 'del_var' is the size that we expect. Let's add
some for better robustness.
Cc: Mike Waychison <mikew@google.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'drivers/firmware/efi/efivars.c')
| -rw-r--r-- | drivers/firmware/efi/efivars.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c index 06ec6ee1c58a..2c21cccc2572 100644 --- a/drivers/firmware/efi/efivars.c +++ b/drivers/firmware/efi/efivars.c @@ -347,6 +347,9 @@ static ssize_t efivar_create(struct file *filp, struct kobject *kobj, if (!capable(CAP_SYS_ADMIN)) return -EACCES; + if (count != sizeof(*new_var)) + return -EINVAL; + attributes = new_var->Attributes; size = new_var->DataSize; data = new_var->Data; @@ -395,6 +398,9 @@ static ssize_t efivar_delete(struct file *filp, struct kobject *kobj, if (!capable(CAP_SYS_ADMIN)) return -EACCES; + if (count != sizeof(*del_var)) + return -EINVAL; + name = del_var->VariableName; vendor = del_var->VendorGuid; |