diff options
| author | Biju Das | 2018-08-07 09:15:18 +0200 |
|---|---|---|
| committer | Linus Walleij | 2018-08-10 23:19:17 +0200 |
| commit | 3789f5acb9bbe088f70779002f32e7c6a64000bc (patch) | |
| tree | c8c19574ef7c1c3ba61666d54d1ba4213a27203e /drivers/gpio/gpiolib.c | |
| parent | gpio: tegra: Include the right header (diff) | |
| download | kernel-qcow2-linux-3789f5acb9bbe088f70779002f32e7c6a64000bc.tar.gz kernel-qcow2-linux-3789f5acb9bbe088f70779002f32e7c6a64000bc.tar.xz kernel-qcow2-linux-3789f5acb9bbe088f70779002f32e7c6a64000bc.zip | |
gpiolib: Avoid calling chip->request() for unused gpios
Add a check for unused gpios to avoid chip->request() call to client
driver for unused gpios.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpiolib.c')
| -rw-r--r-- | drivers/gpio/gpiolib.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 2c457e604403..e8f8a1999393 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2267,6 +2267,7 @@ static int gpiod_request_commit(struct gpio_desc *desc, const char *label) struct gpio_chip *chip = desc->gdev->chip; int status; unsigned long flags; + unsigned offset; spin_lock_irqsave(&gpio_lock, flags); @@ -2285,7 +2286,11 @@ static int gpiod_request_commit(struct gpio_desc *desc, const char *label) if (chip->request) { /* chip->request may sleep */ spin_unlock_irqrestore(&gpio_lock, flags); - status = chip->request(chip, gpio_chip_hwgpio(desc)); + offset = gpio_chip_hwgpio(desc); + if (gpiochip_line_is_valid(chip, offset)) + status = chip->request(chip, offset); + else + status = -EINVAL; spin_lock_irqsave(&gpio_lock, flags); if (status < 0) { |