diff options
| author | Dan Carpenter | 2018-04-24 15:35:49 +0200 |
|---|---|---|
| committer | Oded Gabbay | 2018-04-24 15:35:49 +0200 |
| commit | 8feaccf71dd61f2201493068055e0d1d699014df (patch) | |
| tree | 3ab97c9b0e5b792ebb4d4004be4255e3ffc43542 /drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | |
| parent | drm/amdkfd: Add Vega10 topology and device info (diff) | |
| download | kernel-qcow2-linux-8feaccf71dd61f2201493068055e0d1d699014df.tar.gz kernel-qcow2-linux-8feaccf71dd61f2201493068055e0d1d699014df.tar.xz kernel-qcow2-linux-8feaccf71dd61f2201493068055e0d1d699014df.zip | |
drm/amdkfd: Integer overflows in ioctl
args->n_devices is a u32 that comes from the user. The multiplication
could overflow on 32 bit systems possibly leading to privilege
escalation.
Fixes: 5ec7e02854b3 ("drm/amdkfd: Add ioctls for GPUVM memory management")
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdkfd/kfd_chardev.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index 5694fbead9a5..ce15baf68d4c 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c @@ -1303,8 +1303,8 @@ static int kfd_ioctl_map_memory_to_gpu(struct file *filep, return -EINVAL; } - devices_arr = kmalloc(args->n_devices * sizeof(*devices_arr), - GFP_KERNEL); + devices_arr = kmalloc_array(args->n_devices, sizeof(*devices_arr), + GFP_KERNEL); if (!devices_arr) return -ENOMEM; @@ -1412,8 +1412,8 @@ static int kfd_ioctl_unmap_memory_from_gpu(struct file *filep, return -EINVAL; } - devices_arr = kmalloc(args->n_devices * sizeof(*devices_arr), - GFP_KERNEL); + devices_arr = kmalloc_array(args->n_devices, sizeof(*devices_arr), + GFP_KERNEL); if (!devices_arr) return -ENOMEM; |