diff options
| author | Daniel Vetter | 2012-12-13 23:07:50 +0100 |
|---|---|---|
| committer | Daniel Vetter | 2013-01-20 15:57:57 +0100 |
| commit | af26ef3b3978349cfbd864163a6ebb4906b733b5 (patch) | |
| tree | 38efb55b2aac85582180caa018c26b7c3202e77c /drivers/gpu/drm/ast/ast_main.c | |
| parent | drm/nouveau: try to protect nbo->pin_refcount (diff) | |
| download | kernel-qcow2-linux-af26ef3b3978349cfbd864163a6ebb4906b733b5.tar.gz kernel-qcow2-linux-af26ef3b3978349cfbd864163a6ebb4906b733b5.tar.xz kernel-qcow2-linux-af26ef3b3978349cfbd864163a6ebb4906b733b5.zip | |
drm/<drivers>: Unified handling of unimplemented fb->create_handle
Some drivers don't have real ->create_handle callbacks.
- cirrus/ast/mga200: Returns either 0 or -EINVAL.
- udl: Didn't even bother with a callback, leading to a nice
userspace-triggerable OOPS.
- vmwgfx: This driver bothered with an implementation to return 0 as
the handle (which is the canonical no-obj gem handle).
All have in common that ->create_handle doesn't really make too much
sense for them - that ioctl is used only for seamless fb takeover in
the radeon/nouveau/i915 ddx drivers. So allow drivers to not implement
this and return a consistent -ENODEV.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/ast/ast_main.c')
| -rw-r--r-- | drivers/gpu/drm/ast/ast_main.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index d5ba7097e5b5..f60fd7bd1183 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -246,16 +246,8 @@ static void ast_user_framebuffer_destroy(struct drm_framebuffer *fb) kfree(fb); } -static int ast_user_framebuffer_create_handle(struct drm_framebuffer *fb, - struct drm_file *file, - unsigned int *handle) -{ - return -EINVAL; -} - static const struct drm_framebuffer_funcs ast_fb_funcs = { .destroy = ast_user_framebuffer_destroy, - .create_handle = ast_user_framebuffer_create_handle, }; |