diff options
| author | Jyri Sarha | 2016-01-16 21:17:54 +0100 |
|---|---|---|
| committer | Dave Airlie | 2016-03-08 02:10:03 +0100 |
| commit | dad82ea3ef4b9dc97ca5ec718abc6b0986f1aaaf (patch) | |
| tree | a6946172d253ef397b8cb162b794a08d6e4f3bc9 /drivers/gpu/drm/i2c | |
| parent | drm/vmwgfx: Add back ->detect() and ->fill_modes() (diff) | |
| download | kernel-qcow2-linux-dad82ea3ef4b9dc97ca5ec718abc6b0986f1aaaf.tar.gz kernel-qcow2-linux-dad82ea3ef4b9dc97ca5ec718abc6b0986f1aaaf.tar.xz kernel-qcow2-linux-dad82ea3ef4b9dc97ca5ec718abc6b0986f1aaaf.zip | |
drm/i2c: tda998x: Choose between atomic or non atomic dpms helper
Choose between atomic or non atomic connector dpms helper. If tda998x
is connected to a drm driver that does not support atomic modeset
calling drm_atomic_helper_connector_dpms() causes a crash when the
connectors atomic state is not initialized. The patch implements a
driver specific connector dpms helper that calls
drm_atomic_helper_connector_dpms() if driver supports DRIVER_ATOMIC
and otherwise it calls the legacy drm_helper_connector_dpms().
Fixes commit 9736e988d328 ("drm/i2c: tda998x: Add support for atomic
modesetting").
Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/i2c')
| -rw-r--r-- | drivers/gpu/drm/i2c/tda998x_drv.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 34e38749a817..f8ee740c0e26 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -1382,8 +1382,16 @@ static void tda998x_connector_destroy(struct drm_connector *connector) drm_connector_cleanup(connector); } +static int tda998x_connector_dpms(struct drm_connector *connector, int mode) +{ + if (drm_core_check_feature(connector->dev, DRIVER_ATOMIC)) + return drm_atomic_helper_connector_dpms(connector, mode); + else + return drm_helper_connector_dpms(connector, mode); +} + static const struct drm_connector_funcs tda998x_connector_funcs = { - .dpms = drm_atomic_helper_connector_dpms, + .dpms = tda998x_connector_dpms, .reset = drm_atomic_helper_connector_reset, .fill_modes = drm_helper_probe_single_connector_modes, .detect = tda998x_connector_detect, |