summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/i915_drv.c
diff options
context:
space:
mode:
authorJani Nikula2017-03-10 14:27:57 +0100
committerJani Nikula2017-03-13 10:52:07 +0100
commit665788572c6410b7efadc2e3009c5d830b6d8ef9 (patch)
treee6f6bcc86c5f3d59331e7165d6ea21ba98f451bf /drivers/gpu/drm/i915/i915_drv.c
parentMerge tag 'topic/designware-baytrail-2017-03-02' of git://anongit.freedesktop... (diff)
downloadkernel-qcow2-linux-665788572c6410b7efadc2e3009c5d830b6d8ef9.tar.gz
kernel-qcow2-linux-665788572c6410b7efadc2e3009c5d830b6d8ef9.tar.xz
kernel-qcow2-linux-665788572c6410b7efadc2e3009c5d830b6d8ef9.zip
drm/i915/vbt: don't propagate errors from intel_bios_init()
We don't use the error return for anything other than reporting and logging that there is no VBT. We can pull the logging in the function, and remove the error status return. Moreover, if we needed the information for something later on, we'd probably be better off storing the bit in dev_priv, and using it where it's needed, instead of using the error return. While at it, improve the comments. Cc: Manasi Navare <manasi.d.navare@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/438ebbb0d5f0d321c625065b9cc78532a1dab24f.1489152288.git.jani.nikula@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/i915_drv.c')
-rw-r--r--drivers/gpu/drm/i915/i915_drv.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index b1e9027a4f80..1af54717fa81 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -567,9 +567,7 @@ static int i915_load_modeset_init(struct drm_device *dev)
if (i915_inject_load_failure())
return -ENODEV;
- ret = intel_bios_init(dev_priv);
- if (ret)
- DRM_INFO("failed to find VBIOS tables\n");
+ intel_bios_init(dev_priv);
/* If we have > 1 VGA cards, then we need to arbitrate access
* to the common VGA resources.