summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/i915_gem.c
diff options
context:
space:
mode:
authorChris Wilson2014-05-28 17:16:41 +0200
committerDaniel Vetter2014-06-05 08:52:41 +0200
commitddeff6ee423178246a16875cae0bf033ce1e8455 (patch)
treefb3faacd90e6d1ee7f4090c27780ce3ee6d0d4a7 /drivers/gpu/drm/i915/i915_gem.c
parentdrm/i915: Move the C3 LP write bit setup to gen3_init_clock_gating() for KMS (diff)
downloadkernel-qcow2-linux-ddeff6ee423178246a16875cae0bf033ce1e8455.tar.gz
kernel-qcow2-linux-ddeff6ee423178246a16875cae0bf033ce1e8455.tar.xz
kernel-qcow2-linux-ddeff6ee423178246a16875cae0bf033ce1e8455.zip
drm/i915: Silence the WARN if the user tries to GTT mmap an incoherent object
If the user tries to mmap through the GTT an object that is marked as snooped, we report an error rather than allow the GPU to hang the machine. The choice of EINVAL, however, was unfortunate as we turn that into a WARN rather than a quiet SIGBUS. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_gem.c')
-rw-r--r--drivers/gpu/drm/i915/i915_gem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 89525007925b..ea09d1a0fbd9 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1427,7 +1427,7 @@ int i915_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
/* Access to snoopable pages through the GTT is incoherent. */
if (obj->cache_level != I915_CACHE_NONE && !HAS_LLC(dev)) {
- ret = -EINVAL;
+ ret = -EFAULT;
goto unlock;
}