summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/i915_gem_gtt.h
diff options
context:
space:
mode:
authorChris Wilson2019-04-25 07:43:33 +0200
committerChris Wilson2019-04-25 08:33:57 +0200
commit1f2b4a7edbc3b89c27f661b81a699095d922467c (patch)
treea24cfaed0007b1a51fc5b7c6cca7c24488892d5a /drivers/gpu/drm/i915/i915_gem_gtt.h
parentdrm/i915: Explicitly pin the logical context for execbuf (diff)
downloadkernel-qcow2-linux-1f2b4a7edbc3b89c27f661b81a699095d922467c.tar.gz
kernel-qcow2-linux-1f2b4a7edbc3b89c27f661b81a699095d922467c.tar.xz
kernel-qcow2-linux-1f2b4a7edbc3b89c27f661b81a699095d922467c.zip
drm/i915: Allow multiple user handles to the same VM
It was noted that we made the same mistake for VM_ID as for object handles, whereby we ensured that we only allocated a single handle for one ppgtt. This has the unfortunate consequence for userspace that they need to reference count the handles to avoid destroying an active ID. If we allow multiple handles to the same ppgtt, userspace can freely unreference any handle they own without fear of destroying the same handle in use elsewhere. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190425054333.27299-1-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/i915_gem_gtt.h')
-rw-r--r--drivers/gpu/drm/i915/i915_gem_gtt.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
index f85b75db1f98..2fafa04c45ec 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.h
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
@@ -397,8 +397,6 @@ struct i915_hw_ppgtt {
struct i915_page_directory_pointer pdp; /* GEN8+ */
struct i915_page_directory pd; /* GEN6-7 */
};
-
- u32 user_handle;
};
struct gen6_hw_ppgtt {