diff options
| author | Akash Goel | 2014-01-13 11:54:45 +0100 |
|---|---|---|
| committer | Daniel Vetter | 2014-01-28 09:04:42 +0100 |
| commit | ec14ba47791965d2c08e0a681ff44eacbf3c4553 (patch) | |
| tree | 96dc3e564fb4547c04d8457312c313860121d4de /drivers/gpu/drm/i915/i915_gem_stolen.c | |
| parent | drm/i915: Decouple GPU error reporting from ring initialisation (diff) | |
| download | kernel-qcow2-linux-ec14ba47791965d2c08e0a681ff44eacbf3c4553.tar.gz kernel-qcow2-linux-ec14ba47791965d2c08e0a681ff44eacbf3c4553.tar.xz kernel-qcow2-linux-ec14ba47791965d2c08e0a681ff44eacbf3c4553.zip | |
drm/i915: Fix the offset issue for the stolen GEM objects
The 'offset' field of the 'scatterlist' structure was wrongly
programmed with the offset value from the base of stolen area,
whereas this field indicates the offset from where the interested
data starts within the first PAGE pointed to by 'scattterlist'
structure. As a result when a new GEM object allocated from stolen
area is mapped to GTT, it could lead to an overwrite of GTT entries
as the page count calculation will go wrong, refer the function
'sg_page_count'.
v2: Modified the commit message. (Chris)
Signed-off-by: Akash Goel <akash.goel@intel.com>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: stable@vger.kernel.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71908
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69104
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_gem_stolen.c')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_gem_stolen.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c index fed87ec17211..1a24e84f2315 100644 --- a/drivers/gpu/drm/i915/i915_gem_stolen.c +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c @@ -250,7 +250,7 @@ i915_pages_create_for_stolen(struct drm_device *dev, } sg = st->sgl; - sg->offset = offset; + sg->offset = 0; sg->length = size; sg_dma_address(sg) = (dma_addr_t)dev_priv->mm.stolen_base + offset; |