diff options
| author | Ville Syrjälä | 2016-04-01 17:37:25 +0200 |
|---|---|---|
| committer | Rodrigo Vivi | 2017-10-09 19:33:44 +0200 |
| commit | 7b50f7b24cd6c98541f1af53bddc5b6e861ee8c8 (patch) | |
| tree | cb0d6ec3a96a98cc42d62c37195c73965b72ce9c /drivers/gpu/drm/i915/intel_bios.c | |
| parent | drm/i915: Order two completing nop_submit_request (diff) | |
| download | kernel-qcow2-linux-7b50f7b24cd6c98541f1af53bddc5b6e861ee8c8.tar.gz kernel-qcow2-linux-7b50f7b24cd6c98541f1af53bddc5b6e861ee8c8.tar.xz kernel-qcow2-linux-7b50f7b24cd6c98541f1af53bddc5b6e861ee8c8.zip | |
drm/i915: Read timings from the correct transcoder in intel_crtc_mode_get()
intel_crtc->config->cpu_transcoder isn't yet filled out when
intel_crtc_mode_get() gets called during output probing, so we should
not use it there. Instead intel_crtc_mode_get() figures out the correct
transcoder on its own, and that's what we should use.
If the BIOS boots LVDS on pipe B, intel_crtc_mode_get() would actually
end up reading the timings from pipe A instead (since PIPE_A==0),
which clearly isn't what we want.
It looks to me like this may have been broken by
commit eccb140bca67 ("drm/i915: hw state readout&check support for cpu_transcoder")
as that one removed the early initialization of cpu_transcoder from
intel_crtc_init().
Cc: stable@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Rob Kramer <rob@solution-space.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reported-by: Rob Kramer <rob@solution-space.com>
Fixes: eccb140bca67 ("drm/i915: hw state readout&check support for cpu_transcoder")
References: https://lists.freedesktop.org/archives/dri-devel/2016-April/104142.html
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/1459525046-19425-1-git-send-email-ville.syrjala@linux.intel.com
(cherry picked from commit e30a154b5262b967b133b06ac40777e651045898)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_bios.c')
0 files changed, 0 insertions, 0 deletions