diff options
| author | Imre Deak | 2016-05-12 15:18:50 +0200 |
|---|---|---|
| committer | Imre Deak | 2016-05-13 14:17:58 +0200 |
| commit | d9a7bc67cb356cf6b5597c0af682df9d13dcb1e5 (patch) | |
| tree | 36d82695f2395d9edb8cf4e4981f0be756150328 /drivers/gpu/drm/i915/intel_display.c | |
| parent | drm/i915/gen9: Avoid using negative array index in skl_update_plane() (diff) | |
| download | kernel-qcow2-linux-d9a7bc67cb356cf6b5597c0af682df9d13dcb1e5.tar.gz kernel-qcow2-linux-d9a7bc67cb356cf6b5597c0af682df9d13dcb1e5.tar.xz kernel-qcow2-linux-d9a7bc67cb356cf6b5597c0af682df9d13dcb1e5.zip | |
drm/i915: Add comments about fixed pipe->transcoder/PLL mapping
Code checkers may complain about the explicit casts between different
enum types, so add comments for known-valid cases to help future
triaging of such complaints.
v2:
- Make the comments more logical (Ville).
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1463059132-1720-3-git-send-email-imre.deak@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_display.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index bdccf5038b62..51d007069609 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9290,6 +9290,10 @@ static bool ironlake_get_pipe_config(struct intel_crtc *crtc, ironlake_get_fdi_m_n_config(crtc, pipe_config); if (HAS_PCH_IBX(dev_priv)) { + /* + * The pipe->pch transcoder and pch transcoder->pll + * mapping is fixed. + */ pll_id = (enum intel_dpll_id) crtc->pipe; } else { tmp = I915_READ(PCH_DPLL_SEL); @@ -9840,6 +9844,10 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc, enum intel_display_power_domain power_domain; u32 tmp; + /* + * The pipe->transcoder mapping is fixed with the exception of the eDP + * transcoder handled below. + */ pipe_config->cpu_transcoder = (enum transcoder) crtc->pipe; /* |