diff options
| author | Jani Nikula | 2015-02-05 11:04:27 +0100 |
|---|---|---|
| committer | Daniel Vetter | 2015-02-13 23:28:03 +0100 |
| commit | 60ee5cd24cf1c39d4c7bab7b428a08386a93fe9f (patch) | |
| tree | f52fbb7abe7ec88894e3d743d5a036ebc8188cc8 /drivers/gpu/drm/i915/intel_fbc.c | |
| parent | drm/i915/skl: Declare that GT3 has a second VCS (diff) | |
| download | kernel-qcow2-linux-60ee5cd24cf1c39d4c7bab7b428a08386a93fe9f.tar.gz kernel-qcow2-linux-60ee5cd24cf1c39d4c7bab7b428a08386a93fe9f.tar.xz kernel-qcow2-linux-60ee5cd24cf1c39d4c7bab7b428a08386a93fe9f.zip | |
drm/i915/fbc: fix the check for already reserved fbc size
The check for previously reserved stolen space size for FBC in
i915_gem_stolen_setup_compression() did not take the compression
threshold into account. Fix this by storing and comparing to
uncompressed size instead.
The bug has been introduced in
commit 5e59f7175f96550ede91f58d267d2b551cb6fbba
Author: Ben Widawsky <benjamin.widawsky@intel.com>
Date: Mon Jun 30 10:41:24 2014 -0700
drm/i915: Try harder to get FBC
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88975
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_fbc.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_fbc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index 624d1d92d284..b572bb6ebcff 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -78,7 +78,8 @@ static void i8xx_fbc_enable(struct drm_crtc *crtc) dev_priv->fbc.enabled = true; - cfb_pitch = dev_priv->fbc.size / FBC_LL_SIZE; + /* Note: fbc.threshold == 1 for i8xx */ + cfb_pitch = dev_priv->fbc.uncompressed_size / FBC_LL_SIZE; if (fb->pitches[0] < cfb_pitch) cfb_pitch = fb->pitches[0]; |