diff options
| author | Paulo Zanoni | 2015-11-04 20:10:55 +0100 |
|---|---|---|
| committer | Maarten Lankhorst | 2015-11-10 11:00:34 +0100 |
| commit | 850bfaab7120ae42a433a004d47975cb14fbe972 (patch) | |
| tree | 68ec3dc4bf5a22775de5553bdeb0db6741ff45ff /drivers/gpu/drm/i915/intel_fbc.c | |
| parent | drm/i915: remove too-frequent FBC debug message (diff) | |
| download | kernel-qcow2-linux-850bfaab7120ae42a433a004d47975cb14fbe972.tar.gz kernel-qcow2-linux-850bfaab7120ae42a433a004d47975cb14fbe972.tar.xz kernel-qcow2-linux-850bfaab7120ae42a433a004d47975cb14fbe972.zip | |
drm/i915: clarify that checking the FB stride for CFB is intentional
Daniel was looking at this code and asked about whether fb->pitches[0]
is correct, then he suggested we should a comment to make sure it is
actually intentional.
For more information on the CFB size calculation, please see the
commit message of:
commit c4ffd40908c30a33291227920e921f6b45b9e8f7
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date: Thu Oct 1 19:55:57 2015 -0300
drm/i915: fix CFB size calculation
Requested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1446664257-32012-12-git-send-email-paulo.r.zanoni@intel.com
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_fbc.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_fbc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index b015b0910645..4bd98025e535 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -707,6 +707,7 @@ static int intel_fbc_calculate_cfb_size(struct intel_crtc *crtc) if (INTEL_INFO(dev_priv)->gen >= 7) lines = min(lines, 2048); + /* Hardware needs the full buffer stride, not just the active area. */ return lines * fb->pitches[0]; } |