diff options
| author | Daniele Ceraolo Spurio | 2018-10-02 23:54:29 +0200 |
|---|---|---|
| committer | Chris Wilson | 2018-10-04 08:29:48 +0200 |
| commit | 0fc645f338e3e1a4ee05e5529d86ac596c5921b6 (patch) | |
| tree | a2fc539c68c1801e0e53034f6f3179e6671c1f37 /drivers/gpu/drm/i915/intel_guc_submission.c | |
| parent | drm/i915/guc: init GuC descriptors after GuC load (diff) | |
| download | kernel-qcow2-linux-0fc645f338e3e1a4ee05e5529d86ac596c5921b6.tar.gz kernel-qcow2-linux-0fc645f338e3e1a4ee05e5529d86ac596c5921b6.tar.xz kernel-qcow2-linux-0fc645f338e3e1a4ee05e5529d86ac596c5921b6.zip | |
drm/i915/guc: Don't clear the cookie on doorbell destroy
If the HW has not processed the db invalidation request yet, clearing
the cookie can generate a db ring. We clear the cookie when we
(re-)allocate the doorbell so no need to do it on destroy as well as no
one is going to look at it while the doorbell is inactive
v2: fix typo in patch title (Michal)
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20181002215430.15049-2-daniele.ceraolospurio@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_guc_submission.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_guc_submission.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_guc_submission.c b/drivers/gpu/drm/i915/intel_guc_submission.c index aa4d6bbdd1e9..eae668442ebe 100644 --- a/drivers/gpu/drm/i915/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/intel_guc_submission.c @@ -209,7 +209,6 @@ static void __destroy_doorbell(struct intel_guc_client *client) doorbell = __get_doorbell(client); doorbell->db_status = GUC_DOORBELL_DISABLED; - doorbell->cookie = 0; /* Doorbell release flow requires that we wait for GEN8_DRB_VALID bit * to go to zero after updating db_status before we call the GuC to |