diff options
| author | Chris Wilson | 2019-02-28 11:20:33 +0100 |
|---|---|---|
| committer | Chris Wilson | 2019-02-28 12:07:56 +0100 |
| commit | 32eb6bcfdda9dad240cf6a22fda2b3418b1a1b8e (patch) | |
| tree | b8d37fcf09299b0f0edd9317479336e04a921156 /drivers/gpu/drm/i915/intel_guc_submission.c | |
| parent | drm/i915: Report engines are idle if already parked (diff) | |
| download | kernel-qcow2-linux-32eb6bcfdda9dad240cf6a22fda2b3418b1a1b8e.tar.gz kernel-qcow2-linux-32eb6bcfdda9dad240cf6a22fda2b3418b1a1b8e.tar.xz kernel-qcow2-linux-32eb6bcfdda9dad240cf6a22fda2b3418b1a1b8e.zip | |
drm/i915: Make request allocation caches global
As kmem_caches share the same properties (size, allocation/free behaviour)
for all potential devices, we can use global caches. While this
potential has worse fragmentation behaviour (one can argue that
different devices would have different activity lifetimes, but you can
also argue that activity is temporal across the system) it is the
default behaviour of the system at large to amalgamate matching caches.
The benefit for us is much reduced pointer dancing along the frequent
allocation paths.
v2: Defer shrinking until after a global grace period for futureproofing
multiple consumers of the slab caches, similar to the current strategy
for avoiding shrinking too early.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190228102035.5857-1-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/intel_guc_submission.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_guc_submission.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/intel_guc_submission.c b/drivers/gpu/drm/i915/intel_guc_submission.c index 20cbceeabeae..4366db7978a8 100644 --- a/drivers/gpu/drm/i915/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/intel_guc_submission.c @@ -781,8 +781,7 @@ static bool __guc_dequeue(struct intel_engine_cs *engine) } rb_erase_cached(&p->node, &execlists->queue); - if (p->priority != I915_PRIORITY_NORMAL) - kmem_cache_free(engine->i915->priorities, p); + i915_priolist_free(p); } done: execlists->queue_priority_hint = |