diff options
| author | Daniele Ceraolo Spurio | 2018-10-23 01:04:23 +0200 |
|---|---|---|
| committer | Chris Wilson | 2018-10-23 10:36:52 +0200 |
| commit | bfeabcc87ae0f2dd75bc64f3fedbb6b762b4e5c6 (patch) | |
| tree | c458dce67c508bf5210f36f9383f747df30011fe /drivers/gpu/drm/i915/intel_guc_submission.c | |
| parent | drm/i915/guc: rename __create/destroy_doorbell (diff) | |
| download | kernel-qcow2-linux-bfeabcc87ae0f2dd75bc64f3fedbb6b762b4e5c6.tar.gz kernel-qcow2-linux-bfeabcc87ae0f2dd75bc64f3fedbb6b762b4e5c6.tar.xz kernel-qcow2-linux-bfeabcc87ae0f2dd75bc64f3fedbb6b762b4e5c6.zip | |
drm/i915/guc: reserve the doorbell before selecting the cacheline
Cacheline selection is only needed if we actually manage to reserve a
doorbell.
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20181022230427.5616-2-daniele.ceraolospurio@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_guc_submission.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_guc_submission.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/i915/intel_guc_submission.c b/drivers/gpu/drm/i915/intel_guc_submission.c index b089e5283307..8c3b5a9facee 100644 --- a/drivers/gpu/drm/i915/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/intel_guc_submission.c @@ -955,6 +955,10 @@ guc_client_alloc(struct drm_i915_private *dev_priv, } client->vaddr = vaddr; + ret = reserve_doorbell(client); + if (ret) + goto err_vaddr; + client->doorbell_offset = __select_cacheline(guc); /* @@ -967,10 +971,6 @@ guc_client_alloc(struct drm_i915_private *dev_priv, else client->proc_desc_offset = (GUC_DB_SIZE / 2); - ret = reserve_doorbell(client); - if (ret) - goto err_vaddr; - DRM_DEBUG_DRIVER("new priority %u client %p for engine(s) 0x%x: stage_id %u\n", priority, client, client->engines, client->stage_id); DRM_DEBUG_DRIVER("doorbell id %u, cacheline offset 0x%lx\n", |