diff options
| author | Michel Thierry | 2015-04-27 13:31:44 +0200 |
|---|---|---|
| committer | Daniel Vetter | 2015-05-27 13:20:51 +0200 |
| commit | d63f820f39ee7b3f8dd4ac04ff27511fbf653e9a (patch) | |
| tree | ae5791f8c19352c5af599fbacc6e5b02694204f6 /drivers/gpu/drm/i915/intel_lrc.c | |
| parent | drm/i915: Use spinlocks for checking when to waitboost (diff) | |
| download | kernel-qcow2-linux-d63f820f39ee7b3f8dd4ac04ff27511fbf653e9a.tar.gz kernel-qcow2-linux-d63f820f39ee7b3f8dd4ac04ff27511fbf653e9a.tar.xz kernel-qcow2-linux-d63f820f39ee7b3f8dd4ac04ff27511fbf653e9a.zip | |
drm/i915: Remove unnecessary null check in execlists_context_unqueue
commit 53292cdb066950611e5bc2e0eb109c7edb42af78 ("drm/i915: Workaround
to avoid lite restore with HEAD==TAIL") added a check for req0 != null
which is unnecessary.
The only way req0 could be null is if the list was empty, and this is
already addressed at the beginning of execlists_context_unqueue().
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_lrc.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_lrc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 96ae90affad5..9f5485ddcbe6 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -427,7 +427,7 @@ static void execlists_context_unqueue(struct intel_engine_cs *ring) * WaIdleLiteRestore: make sure we never cause a lite * restore with HEAD==TAIL */ - if (req0 && req0->elsp_submitted) { + if (req0->elsp_submitted) { /* * Apply the wa NOOPS to prevent ring:HEAD == req:TAIL * as we resubmit the request. See gen8_emit_request() |