diff options
| author | Michał Winiarski | 2017-09-18 11:25:35 +0200 |
|---|---|---|
| committer | Chris Wilson | 2017-09-18 12:18:27 +0200 |
| commit | a529a1c9db931a5d4fd6683199d73a8363bc7e83 (patch) | |
| tree | d3e30b4357d7efd5fff9c3c9f20e54c98aa7b874 /drivers/gpu/drm/i915/intel_uc.h | |
| parent | drm/i915/guc: Simplify GuC doorbell logic (diff) | |
| download | kernel-qcow2-linux-a529a1c9db931a5d4fd6683199d73a8363bc7e83.tar.gz kernel-qcow2-linux-a529a1c9db931a5d4fd6683199d73a8363bc7e83.tar.xz kernel-qcow2-linux-a529a1c9db931a5d4fd6683199d73a8363bc7e83.zip | |
drm/i915/guc: Cleanup adding GuC work items
We can just operate on the wq_tail directly (in the process descriptor).
This allows us to remove the duplicated tail from the client. While I'm
here let's also remove the constants kept in the client and document our
locking requirements. This causes a small change in one of GuC debugfs
files. We're no longer reporting constant values (which I don't think
is a problem), but we're also no longer reporting the tail (does anyone
care?).
v2: Update tail after wqi contents. (Chris)
v3: Really update tail after wqi contents.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Oscar Mateo <oscar.mateo@intel.com>
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20170918092536.12287-1-michal.winiarski@intel.com
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_uc.h')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_uc.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h index f505dcccd613..7703c9ad6511 100644 --- a/drivers/gpu/drm/i915/intel_uc.h +++ b/drivers/gpu/drm/i915/intel_uc.h @@ -68,10 +68,6 @@ struct i915_guc_client { unsigned long doorbell_offset; spinlock_t wq_lock; - uint32_t wq_offset; - uint32_t wq_size; - uint32_t wq_tail; - /* Per-engine counts of GuC submissions */ uint64_t submissions[I915_NUM_ENGINES]; }; |