diff options
| author | Philipp Zabel | 2016-10-18 12:30:36 +0200 |
|---|---|---|
| committer | Philipp Zabel | 2016-10-20 14:39:38 +0200 |
| commit | 5fb57ab328aaf313c5ad9c4c48900f632e7c6f1c (patch) | |
| tree | c4982baf5a9e8660ba78eaa8e84ecd2d5568f9d7 /drivers/gpu/drm/imx | |
| parent | drm/imx: ipuv3-plane: Access old u/vbo properly in ->atomic_check for YU12/YV12 (diff) | |
| download | kernel-qcow2-linux-5fb57ab328aaf313c5ad9c4c48900f632e7c6f1c.tar.gz kernel-qcow2-linux-5fb57ab328aaf313c5ad9c4c48900f632e7c6f1c.tar.xz kernel-qcow2-linux-5fb57ab328aaf313c5ad9c4c48900f632e7c6f1c.zip | |
drm/imx: ipuv3-plane: make sure x/y offsets are even in case of chroma subsampling
Odd x/y offsets are not allowed for horizontally/vertically chroma
subsampled planar YUV formats.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Liu Ying <gnuiyl@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/imx')
| -rw-r--r-- | drivers/gpu/drm/imx/ipuv3-plane.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 5c342997863e..e1ad844abafb 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -259,6 +259,7 @@ static int ipu_plane_atomic_check(struct drm_plane *plane, struct drm_framebuffer *fb = state->fb; struct drm_framebuffer *old_fb = old_state->fb; unsigned long eba, ubo, vbo, old_ubo, old_vbo; + int hsub, vsub; /* Ok to disable */ if (!fb) @@ -372,6 +373,16 @@ static int ipu_plane_atomic_check(struct drm_plane *plane, if (old_fb && old_fb->pitches[1] != fb->pitches[1]) crtc_state->mode_changed = true; + + /* + * The x/y offsets must be even in case of horizontal/vertical + * chroma subsampling. + */ + hsub = drm_format_horz_chroma_subsampling(fb->pixel_format); + vsub = drm_format_vert_chroma_subsampling(fb->pixel_format); + if (((state->src_x >> 16) & (hsub - 1)) || + ((state->src_y >> 16) & (vsub - 1))) + return -EINVAL; } return 0; |