diff options
| author | Jani Nikula | 2012-08-15 11:32:39 +0200 |
|---|---|---|
| committer | Dave Airlie | 2012-08-24 01:37:36 +0200 |
| commit | 451023dc32d4542c21b52ad1692e6e01cb75b099 (patch) | |
| tree | 9380bd992f953d0a7403b3894bd1d946b6fbca91 /drivers/gpu/drm/mgag200 | |
| parent | drm/ast: fix EDID memory leak (diff) | |
| download | kernel-qcow2-linux-451023dc32d4542c21b52ad1692e6e01cb75b099.tar.gz kernel-qcow2-linux-451023dc32d4542c21b52ad1692e6e01cb75b099.tar.xz kernel-qcow2-linux-451023dc32d4542c21b52ad1692e6e01cb75b099.zip | |
drm: remove the raw_edid field from struct drm_display_info
Neither the drm core nor any of the drivers really need the raw_edid field
of struct drm_display_info for anything. Instead of being useful, it
creates confusion about who is responsible for freeing the memory it points
to and setting the field to NULL afterwards, leading to memory leaks and
dangling pointers.
Remove the raw_edid field, and fix drivers as necessary.
Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/mgag200')
| -rw-r--r-- | drivers/gpu/drm/mgag200/mgag200_mode.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index b69642d5d850..c7420e83c0b9 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -1399,7 +1399,6 @@ static int mga_vga_get_modes(struct drm_connector *connector) if (edid) { drm_mode_connector_update_edid_property(connector, edid); ret = drm_add_edid_modes(connector, edid); - connector->display_info.raw_edid = NULL; kfree(edid); } return ret; |