diff options
| author | Jia-Ju Bai | 2018-08-04 02:33:44 +0200 |
|---|---|---|
| committer | Alex Deucher | 2018-08-27 18:10:02 +0200 |
| commit | 2f2debb5a162ea9aeb03ad2532827631e3a68b1a (patch) | |
| tree | 20653695ed9e1119952accba6ca919a589f3c1a2 /drivers/gpu/drm/radeon | |
| parent | gpu: drm: radeon: cik: Replace mdelay() with msleep() in cik_pcie_gen3_enable() (diff) | |
| download | kernel-qcow2-linux-2f2debb5a162ea9aeb03ad2532827631e3a68b1a.tar.gz kernel-qcow2-linux-2f2debb5a162ea9aeb03ad2532827631e3a68b1a.tar.xz kernel-qcow2-linux-2f2debb5a162ea9aeb03ad2532827631e3a68b1a.zip | |
gpu: drm: radeon: si: Replace mdelay() with msleep() in si_pcie_gen3_enable()
si_pcie_gen3_enable() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/radeon')
| -rw-r--r-- | drivers/gpu/drm/radeon/si.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c index 85c604d29235..841bc8bc333d 100644 --- a/drivers/gpu/drm/radeon/si.c +++ b/drivers/gpu/drm/radeon/si.c @@ -7183,7 +7183,7 @@ static void si_pcie_gen3_enable(struct radeon_device *rdev) tmp |= LC_REDO_EQ; WREG32_PCIE_PORT(PCIE_LC_CNTL4, tmp); - mdelay(100); + msleep(100); /* linkctl */ pci_read_config_word(root, bridge_pos + PCI_EXP_LNKCTL, &tmp16); |