diff options
| author | Eric Anholt | 2018-06-05 21:03:01 +0200 |
|---|---|---|
| committer | Eric Anholt | 2018-06-21 23:46:05 +0200 |
| commit | 14d1d190869685d3a1e8a3f63924e20594557cb2 (patch) | |
| tree | e098772294a69023decb35b72ecf972e655d62ef /drivers/gpu/drm/v3d/v3d_gem.c | |
| parent | drm/v3d: Take a lock across GPU scheduler job creation and queuing. (diff) | |
| download | kernel-qcow2-linux-14d1d190869685d3a1e8a3f63924e20594557cb2.tar.gz kernel-qcow2-linux-14d1d190869685d3a1e8a3f63924e20594557cb2.tar.xz kernel-qcow2-linux-14d1d190869685d3a1e8a3f63924e20594557cb2.zip | |
drm/v3d: Remove the bad signaled() implementation.
Since our seqno value comes from a counter associated with the GPU
ring, not the entity (aka client), they'll be completed out of order.
There's actually no need for this code at all, since we don't have
enable_signaling() and thus DMA_FENCE_SIGNALED_BIT will be set before
we could be called.
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20180605190302.18279-2-eric@anholt.net
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Diffstat (limited to 'drivers/gpu/drm/v3d/v3d_gem.c')
| -rw-r--r-- | drivers/gpu/drm/v3d/v3d_gem.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 269fe16379c0..e1fcbb4cd0ae 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -654,17 +654,14 @@ void v3d_gem_destroy(struct drm_device *dev) { struct v3d_dev *v3d = to_v3d_dev(dev); - enum v3d_queue q; v3d_sched_fini(v3d); /* Waiting for exec to finish would need to be done before * unregistering V3D. */ - for (q = 0; q < V3D_MAX_QUEUES; q++) { - WARN_ON(v3d->queue[q].emit_seqno != - v3d->queue[q].finished_seqno); - } + WARN_ON(v3d->bin_job); + WARN_ON(v3d->render_job); drm_mm_takedown(&v3d->mm); |