diff options
| author | Chris Wilson | 2010-05-27 15:21:01 +0200 |
|---|---|---|
| committer | Eric Anholt | 2010-05-28 20:02:00 +0200 |
| commit | 9b8c4a0b215e603497daebe8ecbc9b1f0f035808 (patch) | |
| tree | 50aa5824d31631d4b4ec21d5fd23a581d715c092 /drivers/gpu | |
| parent | drm/i915: Cleanup after failed initialization of ringbuffers (diff) | |
| download | kernel-qcow2-linux-9b8c4a0b215e603497daebe8ecbc9b1f0f035808.tar.gz kernel-qcow2-linux-9b8c4a0b215e603497daebe8ecbc9b1f0f035808.tar.xz kernel-qcow2-linux-9b8c4a0b215e603497daebe8ecbc9b1f0f035808.zip | |
drm/i915: Avoid moving from CPU domain during pwrite
We can avoid an early clflush when pwriting if we use the current CPU
write domain rather than moving the object to the GTT domain for the
purposes of the pwrite. This has the advantage of not flushing the
presumably hot data that we want to upload into the bo, and of ascribing
the clflush to the execution when profiling.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Eric Anholt <eric@anholt.net>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_gem.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 42866c01540d..4590c78f4283 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -971,7 +971,8 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data, if (obj_priv->phys_obj) ret = i915_gem_phys_pwrite(dev, obj, args, file_priv); else if (obj_priv->tiling_mode == I915_TILING_NONE && - dev->gtt_total != 0) { + dev->gtt_total != 0 && + obj->write_domain != I915_GEM_DOMAIN_CPU) { ret = i915_gem_gtt_pwrite_fast(dev, obj, args, file_priv); if (ret == -EFAULT) { ret = i915_gem_gtt_pwrite_slow(dev, obj, args, |