diff options
| author | Henrik Rydberg | 2011-01-22 20:55:39 +0100 |
|---|---|---|
| committer | Guenter Roeck | 2011-01-23 18:28:50 +0100 |
| commit | 9d1f8a40ddab65a5cedb69b369ee4c0c6e4acf6b (patch) | |
| tree | 7ab9582fc96b1d4d5fe5cd67cb8b01a0bfb960be /drivers/hwmon/applesmc.c | |
| parent | Linux 2.6.38-rc2 (diff) | |
| download | kernel-qcow2-linux-9d1f8a40ddab65a5cedb69b369ee4c0c6e4acf6b.tar.gz kernel-qcow2-linux-9d1f8a40ddab65a5cedb69b369ee4c0c6e4acf6b.tar.xz kernel-qcow2-linux-9d1f8a40ddab65a5cedb69b369ee4c0c6e4acf6b.zip | |
hwmon: (applesmc) Properly initialize lockdep attributes
The switch to dynamically allocated sysfs attributes left the
internal lockdep members uninitialized, causing a formal bug.
This patch adds sysfs_attr_init() to the node creation function,
remedying the problem.
Reported-and-tested-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Diffstat (limited to 'drivers/hwmon/applesmc.c')
| -rw-r--r-- | drivers/hwmon/applesmc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index ce0372f0615e..4c0743660e9c 100644 --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c @@ -1072,6 +1072,7 @@ static int applesmc_create_nodes(struct applesmc_node_group *groups, int num) node->sda.dev_attr.show = grp->show; node->sda.dev_attr.store = grp->store; attr = &node->sda.dev_attr.attr; + sysfs_attr_init(attr); attr->name = node->name; attr->mode = S_IRUGO | (grp->store ? S_IWUSR : 0); ret = sysfs_create_file(&pdev->dev.kobj, attr); |