summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/f75375s.c
diff options
context:
space:
mode:
authorRiku Voipio2007-10-18 15:29:53 +0200
committerMark M. Hoffman2007-11-08 14:42:46 +0100
commit19e4f3a616ce1753a21b1125fd1923ea6273cd0d (patch)
treeb76896bf6e99db727070e5a5d5dcf6cb643ba3bd /drivers/hwmon/f75375s.c
parenthwmon: (ibmpex.c) fix NULL dereference (diff)
downloadkernel-qcow2-linux-19e4f3a616ce1753a21b1125fd1923ea6273cd0d.tar.gz
kernel-qcow2-linux-19e4f3a616ce1753a21b1125fd1923ea6273cd0d.tar.xz
kernel-qcow2-linux-19e4f3a616ce1753a21b1125fd1923ea6273cd0d.zip
hwmon: (f75375s) fix pwm mode setting
Spotted by the Coverity checker. (Thanks Adrian Bunk) Signed-off-by: Riku Voipio <riku.voipio@iki.fi> Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
Diffstat (limited to 'drivers/hwmon/f75375s.c')
-rw-r--r--drivers/hwmon/f75375s.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
index 13a041326a04..59a3470d6cf9 100644
--- a/drivers/hwmon/f75375s.c
+++ b/drivers/hwmon/f75375s.c
@@ -323,7 +323,7 @@ static ssize_t set_pwm_mode(struct device *dev, struct device_attribute *attr,
int val = simple_strtoul(buf, NULL, 10);
u8 conf = 0;
- if (val != 0 || val != 1 || data->kind == f75373)
+ if (!(val == 0 || val == 1) || data->kind == f75373)
return -EINVAL;
mutex_lock(&data->update_lock);