diff options
| author | Eddie James | 2019-07-02 17:47:42 +0200 |
|---|---|---|
| committer | Joel Stanley | 2019-07-03 03:11:22 +0200 |
| commit | afd26118f0dcf29db031a213f6f95c46ff3bdcbe (patch) | |
| tree | c0bfe617ef7e18bff6fb23bd3cafc131691271df /drivers/hwmon/occ | |
| parent | MAINTAINERS: Add FSI subsystem (diff) | |
| download | kernel-qcow2-linux-afd26118f0dcf29db031a213f6f95c46ff3bdcbe.tar.gz kernel-qcow2-linux-afd26118f0dcf29db031a213f6f95c46ff3bdcbe.tar.xz kernel-qcow2-linux-afd26118f0dcf29db031a213f6f95c46ff3bdcbe.zip | |
OCC: FSI and hwmon: Add sequence numbering
Sequence numbering of the commands submitted to the OCC is required by
the OCC interface specification. Add sequence numbering and check for
the correct sequence number on the response.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Lei YU <mine260309@gmail.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Diffstat (limited to 'drivers/hwmon/occ')
| -rw-r--r-- | drivers/hwmon/occ/common.c | 4 | ||||
| -rw-r--r-- | drivers/hwmon/occ/common.h | 1 |
2 files changed, 3 insertions, 2 deletions
diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c index 13a6290c8d25..cccf91742c1a 100644 --- a/drivers/hwmon/occ/common.c +++ b/drivers/hwmon/occ/common.c @@ -124,12 +124,12 @@ struct extended_sensor { static int occ_poll(struct occ *occ) { int rc; - u16 checksum = occ->poll_cmd_data + 1; + u16 checksum = occ->poll_cmd_data + occ->seq_no + 1; u8 cmd[8]; struct occ_poll_response_header *header; /* big endian */ - cmd[0] = 0; /* sequence number */ + cmd[0] = occ->seq_no++; /* sequence number */ cmd[1] = 0; /* cmd type */ cmd[2] = 0; /* data length msb */ cmd[3] = 1; /* data length lsb */ diff --git a/drivers/hwmon/occ/common.h b/drivers/hwmon/occ/common.h index fc13f3c73c47..67e6968b8978 100644 --- a/drivers/hwmon/occ/common.h +++ b/drivers/hwmon/occ/common.h @@ -95,6 +95,7 @@ struct occ { struct occ_sensors sensors; int powr_sample_time_us; /* average power sample time */ + u8 seq_no; u8 poll_cmd_data; /* to perform OCC poll command */ int (*send_cmd)(struct occ *occ, u8 *cmd); |