summaryrefslogtreecommitdiffstats
path: root/drivers/ide/pdc202xx_old.c
diff options
context:
space:
mode:
authorSergei Shtylyov2010-04-14 07:52:59 +0200
committerDavid S. Miller2010-04-23 04:11:24 +0200
commitf693be4d8a00431b53a59d74aefdb3f7ae92f662 (patch)
tree7b4d930d91a22ac47f5ad4337174dd5ffb9aa24e /drivers/ide/pdc202xx_old.c
parentpdc202xx_old: wire test_irq() method for PDC2026x (diff)
downloadkernel-qcow2-linux-f693be4d8a00431b53a59d74aefdb3f7ae92f662.tar.gz
kernel-qcow2-linux-f693be4d8a00431b53a59d74aefdb3f7ae92f662.tar.xz
kernel-qcow2-linux-f693be4d8a00431b53a59d74aefdb3f7ae92f662.zip
pdc202xx_old: ignore "FIFO empty" bit in test_irq() method
The driver takes into account not only the interrupt status bit but also "FIFO empty" bit in its test_irq() method. This actually is a superfluous check since for the DMA commands calling the dma_test_irq() method further in the interrupt handler makes sure FIFO is emptied. Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ide/pdc202xx_old.c')
-rw-r--r--drivers/ide/pdc202xx_old.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ide/pdc202xx_old.c b/drivers/ide/pdc202xx_old.c
index 42ad794dfaae..3a35ec6193d2 100644
--- a/drivers/ide/pdc202xx_old.c
+++ b/drivers/ide/pdc202xx_old.c
@@ -93,13 +93,13 @@ static int pdc202xx_test_irq(ide_hwif_t *hwif)
* bit 7: error, bit 6: interrupting,
* bit 5: FIFO full, bit 4: FIFO empty
*/
- return ((sc1d & 0x50) == 0x50) ? 1 : 0;
+ return (sc1d & 0x40) ? 1 : 0;
} else {
/*
* bit 3: error, bit 2: interrupting,
* bit 1: FIFO full, bit 0: FIFO empty
*/
- return ((sc1d & 0x05) == 0x05) ? 1 : 0;
+ return (sc1d & 0x04) ? 1 : 0;
}
}