diff options
| author | Florian Westphal | 2019-05-31 18:27:09 +0200 |
|---|---|---|
| committer | David S. Miller | 2019-06-03 03:08:36 +0200 |
| commit | 2638eb8b50cfc16240e0bb080b9afbf541a9b39d (patch) | |
| tree | 84264a6f50aaedfac6854bef3d5972926d321c10 /drivers/infiniband/hw/nes/nes.c | |
| parent | drivers: use in_dev_for_each_ifa_rtnl/rcu (diff) | |
| download | kernel-qcow2-linux-2638eb8b50cfc16240e0bb080b9afbf541a9b39d.tar.gz kernel-qcow2-linux-2638eb8b50cfc16240e0bb080b9afbf541a9b39d.tar.xz kernel-qcow2-linux-2638eb8b50cfc16240e0bb080b9afbf541a9b39d.zip | |
net: ipv4: provide __rcu annotation for ifa_list
ifa_list is protected by rcu, yet code doesn't reflect this.
Add the __rcu annotations and fix up all places that are now reported by
sparse.
I've done this in the same commit to not add intermediate patches that
result in new warnings.
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/infiniband/hw/nes/nes.c')
| -rw-r--r-- | drivers/infiniband/hw/nes/nes.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index e00add6d78ec..29b324726ea6 100644 --- a/drivers/infiniband/hw/nes/nes.c +++ b/drivers/infiniband/hw/nes/nes.c @@ -183,7 +183,13 @@ static int nes_inetaddr_event(struct notifier_block *notifier, rcu_read_lock(); in = __in_dev_get_rcu(upper_dev); - nesvnic->local_ipaddr = in->ifa_list->ifa_address; + if (in) { + struct in_ifaddr *ifa; + + ifa = rcu_dereference(in->ifa_list); + if (ifa) + nesvnic->local_ipaddr = ifa->ifa_address; + } rcu_read_unlock(); } else { nesvnic->local_ipaddr = ifa->ifa_address; |