diff options
| author | Roland Dreier | 2005-10-11 20:08:24 +0200 |
|---|---|---|
| committer | Roland Dreier | 2005-10-18 00:20:29 +0200 |
| commit | 5b6810e048435de508ef66aebd6b78db13d651b8 (patch) | |
| tree | b54df96d5821a6ed41d778bf1ecfb54dbc7a4999 /drivers/infiniband/ulp/ipoib/ipoib_ib.c | |
| parent | [IB] mthca: Better limit checking and reporting (diff) | |
| download | kernel-qcow2-linux-5b6810e048435de508ef66aebd6b78db13d651b8.tar.gz kernel-qcow2-linux-5b6810e048435de508ef66aebd6b78db13d651b8.tar.xz kernel-qcow2-linux-5b6810e048435de508ef66aebd6b78db13d651b8.zip | |
[IPoIB] Rename ipoib_create_qp() -> ipoib_init_qp() and fix error cleanup
ipoib_create_qp() no longer creates IPoIB's QP, so it shouldn't
destroy the QP on failure -- that unwinding happens elsewhere, so the
current code can cause a double free. While we're at it, the
function's name should match what it actually does, so rename it to
ipoib_init_qp().
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband/ulp/ipoib/ipoib_ib.c')
| -rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_ib.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c index f7440096b5ed..02d0e0006578 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c @@ -387,9 +387,9 @@ int ipoib_ib_dev_open(struct net_device *dev) struct ipoib_dev_priv *priv = netdev_priv(dev); int ret; - ret = ipoib_qp_create(dev); + ret = ipoib_init_qp(dev); if (ret) { - ipoib_warn(priv, "ipoib_qp_create returned %d\n", ret); + ipoib_warn(priv, "ipoib_init_qp returned %d\n", ret); return -1; } |